linux-ext4 - Re: [ltt-dev] LTTng 0.89 for Linux 2.6.29-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090208154711.GA527@linux.vnet.ibm.com>
Date:	Sun, 8 Feb 2009 07:47:11 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Mathieu Desnoyers <compudj@...stal.dyndns.org>
Cc:	Trilok Soni <soni.trilok@...il.com>, ltt-dev@...ts.casi.polymtl.ca,
	Ext4 Developers List <linux-ext4@...r.kernel.org>,
	"Theodore Ts'o" <tytso@....edu>, linux-kernel@...r.kernel.org
Subject: Re: [ltt-dev] LTTng 0.89 for Linux 2.6.29-rc3

On Fri, Feb 06, 2009 at 01:37:01PM -0800, Paul E. McKenney wrote:
> On Fri, Feb 06, 2009 at 03:03:29PM -0500, Mathieu Desnoyers wrote:
> > * Paul E. McKenney (paulmck@...ux.vnet.ibm.com) wrote:
> > > On Thu, Feb 05, 2009 at 09:00:05PM -0500, Mathieu Desnoyers wrote:
> > > > * Paul E. McKenney (paulmck@...ux.vnet.ibm.com) wrote:

[ . . . ]

> > > > >   CC      arch/powerpc/kernel/asm-offsets.s
> > > > > In file included from include/linux/module.h:18,
> > > > >                  from include/linux/sysdev.h:25,
> > > > >                  from include/linux/node.h:22,
> > > > >                  from include/linux/swap.h:10,
> > > > >                  from include/linux/suspend.h:7,
> > > > >                  from arch/powerpc/kernel/asm-offsets.c:24:
> > > > > include/linux/immediate.h:15:27: error: asm/immediate.h: No such file or directory
> > > > > In file included from include/linux/module.h:18,
> > > > >                  from include/linux/sysdev.h:25,
> > > > >                  from include/linux/node.h:22,
> > > > >                  from include/linux/swap.h:10,
> > > > >                  from include/linux/suspend.h:7,
> > > > >                  from arch/powerpc/kernel/asm-offsets.c:24:
> > > > > include/linux/immediate.h:37: warning: â€˜struct __imvâ€™ declared
> > > > > inside parameter list
> > > > > include/linux/immediate.h:37: warning: its scope is only this definition
> > > > > or declaration, which is probably not what you want
> > > > > include/linux/immediate.h:40: warning: â€˜struct __imvâ€™ declared
> > > > > inside parameter list
> > > > > make[1]: *** [arch/powerpc/kernel/asm-offsets.s] Error 1
> > > > > make: *** [prepare0] Error 2
> > > > > 02/05/2009-17:57:41 Build the kernel. Failed rc = 2
> > > > > 02/05/2009-17:57:41 build: Building kernel... Failed rc = 1
> > > > > 
> > > > 
> > > > Hrm, does the file
> > > > 
> > > > arch/powerpc/include/asm/immediate.h exist in your tree ?
> > > > 
> > > > Here, with the setup done following the commands I gave you (minus the
> > > > mkdir patch), I get :
> > > > 
> > > > 
> > > > compudj@ok:~$ head testpaulmck/linux-2.6.29-rc3/arch/powerpc/include/asm/immediate.h 
> > > > #ifndef _ASM_POWERPC_IMMEDIATE_H
> > > > #define _ASM_POWERPC_IMMEDIATE_H
> > > > 
> > > > /*
> > > >  * Immediate values. PowerPC architecture optimizations.
> > > >  *
> > > >  * (C) Copyright 2006 Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
> > > >  *
> > > >  * This file is released under the GPLv2.
> > > >  * See the file COPYING for more details.
> > > > 
> > > > ....
> > > > 
> > > > Which defines struct __imv. So hrm, normally the header should be there.
> > > > (/me still confused) :)
> > > 
> > > It does indeed, see the patch I generated against 2.6.29-rc3:
> > > 
> > > 	http://www.rdrop.com/users/paulmck/patches/2.6.29-rc3-ltt-1.patch
> > > 
> > > I get a similar failure on x86 -- perhaps my tools or build environment
> > > does not match yours?
> > > 
> > 
> > Maybe. If you want a quick and dirty solution, try :
> > 
> > CONFIG_IMMEDIATE=n
> > 
> > Immediate values are just an optimization, not necessary anyway.
> 
> K -- kicking it off.

One thing that helps on 32-bit x86 is removing the "select HAVE_IMMEDIATE"
that you added to arch/x86/Kconfig.  I then get assembly errors:

	  AS      arch/x86/kernel/entry_32.o
	arch/x86/kernel/entry_32.S: Assembler messages:
	arch/x86/kernel/entry_32.S:272: Error: invalid character '_' in
	mnemonic
	make[1]: *** [arch/x86/kernel/entry_32.o] Error 1
	make: *** [arch/x86/kernel] Error 2

This seems to point to the following new line:

	INTERRUPT_RETURN_NMI_SAFE

Replacing this with the NATIVE_INTERRUPT_RETURN_NMI_SAFE that appears
elsewhere did not help.

Over to you!

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html