linux-ext4 - Re: [PATCH] Validate extent details only when read from the disk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49900612.3020609@ph.tum.de>
Date:	Mon, 09 Feb 2009 11:31:46 +0100
From:	Thiemo Nagel <thiemo.nagel@...tum.de>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
CC:	tytso@....edu, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] Validate extent details only when read from the disk

Aneesh Kumar K.V wrote:
> Make sure we validate extent details only when read from the disk.
>
> @@ -602,15 +607,13 @@ struct ext4_ext_path *
>  ext4_ext_find_extent(struct inode *inode, ext4_lblk_t block,
>  					struct ext4_ext_path *path)
>  {
> +	int need_to_validate = 0;
>  	struct ext4_extent_header *eh;
>  	struct buffer_head *bh;
>  	short int depth, i, ppos = 0, alloc = 0;
>  
>  	eh = ext_inode_hdr(inode);
>  	depth = ext_depth(inode);
> -	if (ext4_ext_check(inode, eh, depth))
> -		return ERR_PTR(-EIO);
> -

This check needs to stay in.

Kind regards,

Thiemo

-- 
+-----------------------------------+--------------------------+
| Dipl.-Phys. Thiemo Nagel          |                          |
| Technische Universitaet Muenchen  | Room    PH1 3276         |
| Physik-Department E18             |                          |
| James-Franck-Strasse              | Phone  +49 89 289-12379  |
| D-85747 Garching                  | Fax    +49 89 289-12570  |
+-----------------------------------+--------------------------+
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html