linux-ext4 - Re: [PATCH] ext3: Use unsigned instead of int for type of blocksize in fs/ext3/namei.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090215024615.GB10706@mini-me.lan>
Date:	Sat, 14 Feb 2009 21:46:15 -0500
From:	Theodore Tso <tytso@....edu>
To:	Wei Yongjun <yjwei@...fujitsu.com>
Cc:	linux-ext4@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] ext3: Use unsigned instead of int for type of
	blocksize in fs/ext3/namei.c

On Thu, Feb 12, 2009 at 03:15:40PM +0800, Wei Yongjun wrote:
> Use unsigned instead of int for paramter which means blocksize.

Could you please also change size to blocksize, so it's more obvious
what the parameter to dx_make_map() and dx_pack_dirents(), and
resubmit an updated patch to Andrew?  That will make it much more
obvious what is going on.

I'll make the same changes to the patch destined for the ext4 tree myself.

Thanks, regards,

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html