linux-ext4 - Re: EXT3 file system with unsupported revision level can be mounted in R/W mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090217203617.GO23758@mini-me.lan>
Date:	Tue, 17 Feb 2009 15:36:17 -0500
From:	Theodore Tso <tytso@....edu>
To:	Tadao Uchiyama <Tadao.Uchiyama@...adex.co.jp>
Cc:	sandeen@...hat.com, linux-ext4@...r.kernel.org
Subject: Re: EXT3 file system with unsupported revision level can be
	mounted in R/W mode

On Tue, Feb 17, 2009 at 05:50:44PM +0900, Tadao Uchiyama wrote:
> Sorry for the long delay in my response.  I agree that the mount of
> a file with a too-high revision level should be rejected, if the
> current revision level is never going to change again, because the
> too-high revision level must be an indication of some corruption in
> this case.  The problem is when we should fail the mount. It seems
> to be too late to fail the mount after the related super block has
> been updated in group_extend or clear_journal_error.  It’ll be safe
> to make the revision somewhere earlier stage, at least before doing
> clear_journal_error and group_extend.

I'd just probably add something right after the magic number check
(i.e., around line 2072 in fs/ext4/super.c, in ext4_fill_super()).

It's highly unlikely we would ever change the revision number at this
point, given that we have the feature compatibility bitmasks as the
primary way we indicate format changes in the filesystem these days.
So I wouldn't even allow a read-only mount, I'd just fail the mount
altogether, and very early; basically, treat it as part of the magic
number.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html