linux-ext4 - Checking of NULL with __GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea11fea30902282205y14062e72v37780481e93802a3@mail.gmail.com>
Date:	Sun, 1 Mar 2009 11:35:32 +0530
From:	Manish Katiyar <mkatiyar@...il.com>
To:	ext4 <linux-ext4@...r.kernel.org>
Subject: Checking of NULL with __GFP_NOFAIL in kzalloc()

Hi,

While going through jbd code, I was wondering why do we need to check
new_transaction for NULL, if we are passing __GFP_NOFAIL ?
Last code change around this code was when Ted converted kmalloc to
kzalloc, but since he also didn't remove it I am guessing there would
be some good reason for it. Can someone enlighten me ?

start_this_handle() {
..........
	..........
	new_transaction = kzalloc(sizeof(*new_transaction),
			GFP_NOFS|__GFP_NOFAIL);
        if (!new_transaction) {
        	ret = -ENOMEM;
        	goto out;
        }
	..........
}

Thanks -
Manish
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html