linux-ext4 - Re: [PATCH] fix header check in ext4_ext_search

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49B54014.1030805@redhat.com>
Date:	Mon, 09 Mar 2009 11:13:08 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
CC:	Theodore Tso <tytso@....edu>,
	ext4 development <linux-ext4@...r.kernel.org>,
	David Dindorp <ddi@...ex.dk>
Subject: Re: [PATCH] fix header check in ext4_ext_search_right() for deep
 extent trees.

Aneesh Kumar K.V wrote:
> On Mon, Mar 09, 2009 at 07:36:19AM -0400, Theodore Tso wrote:
>> On Fri, Mar 06, 2009 at 02:50:51PM -0600, Eric Sandeen wrote:
>>> This should resolve kernel.org bugzilla 12821
>>>
>>> I've not actually crafted a workload to exercise this code; 
>>> this is from inspection...
>> Hmm, so I've been trying to create a test case, but the test cases
>> I've created (which e2fsck say are fine) aren't causing complaints by
>> the kernel.
>>
>> Please see:
>>
>>        http://master.kernel.org/~tytso/deep-tree/
>>
>> deep-tree.img.gz contains an extent tree of depth 3, and
> 
> With depth 3 we would have path->p_depth = 2 and with middle
> index block would have eh->eh_depth = 1 and depth variable also
> will be having value 1. (also path->p_depth - depth)

>> deep-tree-2.img.gz contains an extent tree of depth 4....
>>

I think this jives w/ what the reporter had, although in the e2image the
problematic inode only had depth 3 (at the time)

for 4 levels, p_depth would be 3, so for

depth		eh_depth	p_depth-depth
0		3		3
1		2		2
2		1		1  <----check got 2, expected 1
3		0		0

he got:

ext4_ext_search_right: bad header in inode #2621457: unexpected eh_depth
- magic f30a, entries 340, max 340(0), depth 1(2)

> So what is the logical block number with which you trying to allocate
> blocks in deep-tree-2.img.gz 

yep that's the key :)

-Eric

> -aneesh

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html