| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1237311235-13623-5-git-send-email-jack@suse.cz> Date: Tue, 17 Mar 2009 18:33:55 +0100 From: Jan Kara <jack@...e.cz> To: LKML <linux-kernel@...r.kernel.org> Cc: linux-ext4@...r.kernel.org, Jan Kara <jack@...e.cz> Subject: [PATCH 4/4] fs: Warn about writing !uptodate buffers Make submit_bh() warn about writing !uptodate buffers. Hopefully this warns us about writing garbage (although bugs in write EIO handling are going to trigger this as well as they already trigger the warning in mark_buffer_dirty()). Signed-off-by: Jan Kara <jack@...e.cz> --- fs/buffer.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/buffer.c b/fs/buffer.c index 22c0144..985f617 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -2997,6 +2997,8 @@ int submit_bh(int rw, struct buffer_head * bh) BUG_ON(!buffer_locked(bh)); BUG_ON(!buffer_mapped(bh)); BUG_ON(!bh->b_end_io); + if (rw & WRITE) + WARN_ON_ONCE(!buffer_uptodate(bh)); /* * Mask in barrier bit for a write (could be either a WRITE or a -- 1.6.0.2 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists