linux-ext4 - Re: [patch] ext4: typo leads to small leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 27 Mar 2009 09:13:29 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Dan Carpenter <error27@...il.com>
CC:	tytso@....edu, adilger@....com, linux-ext4@...r.kernel.org
Subject: Re: [patch] ext4: typo leads to small leak

Dan Carpenter wrote:
> This was found by smatch (http://repo.or.cz/w/smatch.git/)
> 
> regards,
> dan carpenter
> 
> Signed-off-by: Dan Carpenter <error27@...il.com>

Reviewed-by: Eric Sandeen <sandeen@...hat.com>

Thanks!  Maybe one for the stable trees.

> --- orig/fs/ext4/mballoc.c	2009-03-26 18:22:30.000000000 +0300
> +++ devel/fs/ext4/mballoc.c	2009-03-26 18:22:56.000000000 +0300
> @@ -2693,7 +2693,7 @@
>  	i = (sb->s_blocksize_bits + 2) * sizeof(unsigned int);
>  	sbi->s_mb_maxs = kmalloc(i, GFP_KERNEL);
>  	if (sbi->s_mb_maxs == NULL) {
> -		kfree(sbi->s_mb_maxs);
> +		kfree(sbi->s_mb_offsets);
>  		return -ENOMEM;
>  	}
>  
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html