linux-ext4 - Re: locking typo in ext4_mb_add_n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090331130032.GE20127@atrey.karlin.mff.cuni.cz>
Date:	Tue, 31 Mar 2009 15:00:32 +0200
From:	Jan Kara <jack@...e.cz>
To:	Theodore Tso <tytso@....edu>
Cc:	Eric Sandeen <sandeen@...hat.com>,
	Dan Carpenter <error27@...il.com>, adilger@....com,
	linux-ext4@...r.kernel.org
Subject: Re: locking typo in ext4_mb_add_n_trim()

> On Fri, Mar 27, 2009 at 09:16:59AM -0500, Eric Sandeen wrote:
> > 
> > although I wonder why we don't trip over this in spinlock debugging
> > (seems like it'd lead to a double unlock at times)  I wonder if we can
> > tie this to any other bugs we've seen.
> 
> I was wondering if it could be tied to the "rm -rf" soft lockup hang....
> 
> I wonder if vendor kernels (specifically, Ubuntu in this case) disable
> spinlock debugging, which is why we wouldn't have seen the double
> unlock warning.  (Or maybe it happened earlier in the log, and users
> didn't notice it).
  Don't know about Ubuntu but SUSE has definitely turned off spinlock
debugging (I guess because it may cost some performance) and most other
debug stuff.

								Honza
-- 
Jan Kara <jack@...e.cz>
SuSE CR Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html