linux-ext4 - Re: [Bug 12829] kernel complains on ENOSPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 6 Apr 2009 14:58:23 -0400
From:	Theodore Tso <tytso@....edu>
To:	aneesh.kumar@...ux.vnet.ibm.com
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [Bug 12829] kernel complains on ENOSPC

Aneesh,

What's the status of this patch; do you think we still need it?  If
so, can you add a proper commit log and signed-off-by, tell me that
you've tested it, etc.?

Thanks!!

	    	    	  	 - Ted


On Tue, Mar 10, 2009 at 09:38:24AM -0700, bugme-daemon@...zilla.kernel.org wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=12829
> 
> 
> 
> 
> 
> ------- Comment #4 from aneesh.kumar@...ux.vnet.ibm.com  2009-03-10 09:38 -------
> This patch will not fix the problem. But i guess we need this change
> 
> -aneesh
> 
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 4415bee..671f215 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -4652,11 +4652,11 @@ out1:
>         if (ar->len < inquota)
>                 DQUOT_FREE_BLOCK(ar->inode, inquota - ar->len);
>  out3:
> -       if (!ar->len) {
> +       if (ar->len < reserv_blks) {
>                 if (!EXT4_I(ar->inode)->i_delalloc_reserved_flag)
>                         /* release all the reserved blocks if non delalloc */
>                         percpu_counter_sub(&sbi->s_dirtyblocks_counter,
> -                                               reserv_blks);
> +                                               reserv_blks - ar->len);
>         }
> 
>         trace_mark(ext4_allocate_blocks,
> 
> 
> -- 
> Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html