linux-ext4 - Re: [PATCH e2fsprogs] Add ZFS detection to libblkid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090406203527.GB6800@nb.net.home>
Date:	Mon, 6 Apr 2009 22:35:28 +0200
From:	Karel Zak <kzak@...hat.com>
To:	"Ricardo M. Correia" <Ricardo.M.Correia@....COM>
Cc:	Andreas Dilger <adilger@....COM>,
	Eric Sandeen <sandeen@...hat.com>,
	"Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH e2fsprogs] Add ZFS detection to libblkid

On Mon, Apr 06, 2009 at 08:22:38PM +0100, Ricardo M. Correia wrote:
> So I think you're (mostly) right - in theory, a correct implementation
> would have to search all the uberblock slots in all the 4 labels (2 at
> the beginning of the partition and 2 at the end), for a total of 512
> magic offsets, but this is not easy to do with libblkid because it only
> looks for the magic values at hard-coded offsets (as opposed to being
> able to implement a routine to look for a filesystem, which could use a
> simple "for" statement).

 Note that the new libblkid version (in util-linux-ng) could use a
 simple "for" statement (see ufs.c or *_raid.c), but the "magic value
 at hard-coded offset" is a better (cheaper) method.

    Karel

-- 
 Karel Zak  <kzak@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html