linux-ext4 - Re: [patch] missing unlock in ext2_quota

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090409160958.GB26552@atrey.karlin.mff.cuni.cz>
Date:	Thu, 9 Apr 2009 18:09:58 +0200
From:	Jan Kara <jack@...e.cz>
To:	Dan Carpenter <error27@...il.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [patch] missing unlock in ext2_quota_write()

> The inode->i_mutex should be unlocked.
> 
> Found by smatch (http://repo.or.cz/w/smatch.git).  Compile tested.
> 
> regards,
> dan carpenter
> 
> Signed-off-by: Dan Carpenter <error27@...il.com>
  Thanks for the fix. Merged into quota tree.

								Honza
> 
> --- orig/fs/ext2/super.c	2009-04-07 08:42:15.000000000 +0300
> +++ devel/fs/ext2/super.c	2009-04-07 08:43:19.000000000 +0300
> @@ -1394,8 +1394,10 @@
>  		blk++;
>  	}
>  out:
> -	if (len == towrite)
> +	if (len == towrite) {
> +		mutex_unlock(&inode->i_mutex);
>  		return err;
> +	}
>  	if (inode->i_size < off+len-towrite)
>  		i_size_write(inode, off+len-towrite);
>  	inode->i_version++;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
Jan Kara <jack@...e.cz>
SuSE CR Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html