linux-ext4 - Re: [PATCH e2fsprogs] Add ZFS detection to libblkid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090417095136.GA12255@nb.net.home>
Date:	Fri, 17 Apr 2009 11:51:36 +0200
From:	Karel Zak <kzak@...hat.com>
To:	"Ricardo M. Correia" <Ricardo.M.Correia@....COM>
Cc:	Andreas Dilger <adilger@....COM>,
	Eric Sandeen <sandeen@...hat.com>,
	"Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH e2fsprogs] Add ZFS detection to libblkid

On Mon, Apr 13, 2009 at 08:29:22PM +0100, Ricardo M. Correia wrote:
> On Ter, 2009-04-07 at 00:40 -0700, Andreas Dilger wrote:
> > > However, even though currently it's txg nr 4 that gets written first,
> > > this is an implementation-specific detail that we cannot (or should not)
> > > rely upon.
> > 
> > So my proposal to check the 0th, 4th, and 8th überblock in both
> > the first and second VDEV label should be pretty safe.
> 
> Yes, that should be relatively safe :)
> 
> Where should I be sending patches for this? e2fsprogs, util-linux-ng,
> libvolume_id in udev, ... all of them?

Please,

  git://git.kernel.org/pub/scm/utils/util-linux-ng/util-linux-ng.git

currently the libs/blkid/src/probers/zfs.c file contains the original
Andreas's probing code. Note that you needn't to use hard-coded
offsets (see for example ufs.c).

I'll eventually port your patch to libvolume_id and e2fsprogs.

Thanks.

    Karel

-- 
 Karel Zak  <kzak@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html