linux-ext4 - Re: [PATCH 1/2][64-BIT] blk_t -> blk64_t in read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49E9D5AC.80703@redhat.com>
Date:	Sat, 18 Apr 2009 08:29:16 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	nicholas.dokos@...com
CC:	linux-ext4@...r.kernel.org, "Theodore Ts'o" <tytso@....edu>,
	Valerie Aurora <vaurora@...hat.com>
Subject: Re: [PATCH 1/2][64-BIT] blk_t -> blk64_t in read_bitmaps().

Nick Dokos wrote:
> e2fsck -n -f on a brand-new, never-mounted 32TiB filesystem was
> detecting a lot of "Block bitmap differences". This change makes them
> go away (there are are still more problems however: the run finds used
> blocks in one BLOCK_UNINIT group and a free block mismatch.)
> 
> Signed-off-by: Nick Dokos <nicholas.dokos@...com>

Looks right to me as well.

Reviewed-by: Eric Sandeen <sandeen@...hat.com>

> ---
>  lib/ext2fs/rw_bitmaps.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/ext2fs/rw_bitmaps.c b/lib/ext2fs/rw_bitmaps.c
> index cee6142..5b504bf 100644
> --- a/lib/ext2fs/rw_bitmaps.c
> +++ b/lib/ext2fs/rw_bitmaps.c
> @@ -144,9 +144,9 @@ static errcode_t read_bitmaps(ext2_filsys fs, int do_inode, int do_block)
>  	int csum_flag = 0;
>  	int do_image = fs->flags & EXT2_FLAG_IMAGE_FILE;
>  	unsigned int	cnt;
> -	blk_t	blk;
> -	blk_t	blk_itr = fs->super->s_first_data_block;
> -	blk_t   blk_cnt;
> +	blk64_t	blk;
> +	blk64_t	blk_itr = fs->super->s_first_data_block;
> +	blk64_t   blk_cnt;
>  	ext2_ino_t ino_itr = 1;
>  	ext2_ino_t ino_cnt;
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html