linux-ext4 - Re: [PATCH 1/3] ext4: Properly initialize the buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090511113106.GE29082@mit.edu>
Date:	Mon, 11 May 2009 07:31:06 -0400
From:	Theodore Tso <tytso@....edu>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	Eric Sandeen <sandeen@...hat.com>, cmm@...ibm.com,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/3] ext4: Properly initialize the buffer_head state

On Mon, May 11, 2009 at 02:54:43PM +0530, Aneesh Kumar K.V wrote:
> On Sun, May 10, 2009 at 07:57:41PM -0400, Theodore Tso wrote:
> > On Thu, May 07, 2009 at 10:20:26AM -0500, Eric Sandeen wrote:
> > > Aneesh Kumar K.V wrote:
> > > > These buffer_heads are allocated on stack and are
> > > > used only to make get_blocks calls. So we can set the
> > > > b_state to 0
> > > > 
> > > > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@...ux.vnet.ibm.com>
> > > 
> > > I'd noticed this too, thanks for fixing up.
> > 
> > Is this just a clean-up, or does this fix a bug?  It wasn't obvious
> > the patch description.  (I'm not a big fan of Ingo's 'Impact: '
> > header, but it is good to make sure the patch description explains the
> > impact of a patch.)
> 
> If you are taking patch 3/3 you would need this patch. But otherwise you
> can drop this. The fix is actually in patch 2/3.

OK, thanks.  And these patches are orthogonal to these patches in the
patch queue, right?

      fix-sub-block-zeroing-for-unwritten-extents
      use-a-fake-block-number-for-delalloc-bh

So it looks like we probably want to push these two, plus patch 2/3.
I'm also very much concerned about your for-2.6.31 patch.  It is
complex, so we probably want wait, but it looks like we have a real
bug which these patches will just expose.  And your 2/3 patch isn't
going to fix that, right, since these are orthogonal problems.

(Again, if you expect patches to supercede existing ones in the ext4
patchwork or which are in the patch queue, please tell me.  Sometimes
it really isn't obvious....)

						- Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html