linux-ext4 - Re: [PATCH] EXT3: Change all super.c messages to print the device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A1426BE.2010101@redhat.com>
Date:	Wed, 20 May 2009 10:50:22 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Andi Kleen <andi@...stfloor.org>
CC:	Theodore Tso <tytso@....edu>, Jan Kara <jack@...e.cz>,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] EXT3: Change all super.c messages to print the device

Andi Kleen wrote:
>> I'll do that, unless anyone's already started.
> 
> Fine by me. I haven't done anything on it. Ideally ext2 too.
> 
>> There's a bit of inconsistency in the patch between:
>>
>> ext3_msg(sb, KERN_ERR "message");
>> and
>> ext3_msg(sb, KERN_ERR, "message");
>>
>> just FWIW.
> 
> Where? 
> 
> % grep '^+' ext3-msg  | grep 'KERN[_A-Z]+[^,]'
            ^^ext3_msg^^

> %
> 
> The missing comma would probably not compile.
> 
> -Andi
> 

Just a one I guess:

$ grep '^+' patch | grep 'KERN[_A-Z]\+[ $]'
+			ext3_msg(sb, KERN_ERR "(no)acl options not supported");
+	printk(KERN_INFO "EXT3-FS (%s): ", sb->s_id);

-Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html