linux-ext4 - Re: [PATCH] libext2fs: write only core inode in update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A395555.2070308@redhat.com>
Date:	Wed, 17 Jun 2009 15:43:01 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	number9652 <number9652@...oo.com>
CC:	Theodore Tso <tytso@....edu>,
	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] libext2fs: write only core inode in update_path()

number9652 wrote:
> --- On Wed, 6/17/09, Eric Sandeen wrote:
>> Theodore Tso wrote:
>>> Probably it would be better/simpler to replace this
>> with:
>>> retval =
>> ext2fs_write_inode(handle->fs, handle->ino, handle->inode); - Ted
>>> 
>> Sure, that makes more sense, revised below:
>> 
>> libext2fs: write only core inode in update_path()
>> 
>> The ext2_extent_handle only has a struct ext2_inode allocated on 
>> it, and the same amount copied into it in that same function,
> 
> First, sorry for the original bug.  I don't think the above is the
> right way to fix it, however.  I am concerned that I may have
> basically broken write_inode_full on any inode with extents.  For
> example, there is another call to write_inode_full in extent.c that
> might exhibit this same problem.  I think the right fix would be to
> return to reading the full inode into memory in the extent_open
> function.  See the patch below for what I am talking about.

Hm, well, I wondered about that.  IMHO having these 2 inode sizes is a
big pain in the butt, and the shuffling back and forth is just asking
for bugs.

If this is the case (that it's broken now), then we really need
something in the regression suite to catch it - all tests pass in 1.41.6
....

-Eric


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html