linux-ext4 - Re: [RFC][PATCH 2/7]ext4: Add EXT4_IOC_CLR_GLOBAL_ALLOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A41E1BF.3090805@rs.jp.nec.com>
Date:	Wed, 24 Jun 2009 17:20:15 +0900
From:	Akira Fujita <a-fujita@...jp.nec.com>
To:	Andreas Dilger <adilger@....com>
CC:	"Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [RFC][PATCH 2/7]ext4: Add EXT4_IOC_CLR_GLOBAL_ALLOC_RULE	clears
 block allocation restriction

Hi Andreas,

Andreas Dilger wrote:
> On Jun 23, 2009  17:25 +0900, Akira Fujita wrote:
>> Block allocation restriction is cleared with this ioctl or umount filesystem.
>>
>>  #define EXT4_IOC_CLR_GLOBAL_ALLOC_RULE _IOW('f', 17, struct ext4_alloc_rule);
>>
>>   struct ext4_alloc_rule {
>>         __u64 start;            /* start physical offset to clear rule */
>>         __u64 len;              /* number of blocks to be clear */
>>         __u32 alloc_flag;       /* not used, should be zero */
>>   };
> 
> Why not call EXT4_IOC_ADD_GLOBAL_ALLOC_RULE with a "clear" flag?

Yes, having "clear" flag makes more sense
than implementing ioctls separately.

I will add "clear" flag (EXT4_MB_CLEAR_ALLOC_RULE) to alloc_flag
and remove EXT4_IOC_CLR_GLOBAL_ALLOC_RULE ioctl in the next version.

Thanks,
Akira Fujita
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html