linux-ext4 - Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090628133430.GA3594@mit.edu>
Date:	Sun, 28 Jun 2009 09:34:30 -0400
From:	Theodore Tso <tytso@....edu>
To:	Scott James Remnant <scott@...ntu.com>
Cc:	Karel Zak <kzak@...hat.com>, Andrey Borzenkov <arvidjaar@...l.ru>,
	util-linux-ng@...r.kernel.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] configure.in: add --disable-libuuid option (Was:
	libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

Sorry for the delay; I've been incredibly busy.  I'm guessing you
never actually bothered to build and test the patch which you
submitted?

I tried building with --disable-libuuid, when it tried to compile
e2fsck, it crashed and burned.  The reason why was because LIBUUID
wasn't getting set properly:

% grep LIBUUID MCONFIG  | head -1
LIBUUID =  

And the reason for that is....

On Wed, Jun 03, 2009 at 10:39:05AM +0100, Scott James Remnant wrote:
> +AC_ARG_ENABLE([libuuid],
> +[  --disable-libuuid	  do not build private uuid library],
> +if test "$enableval" = "no"
> +then
> +	if test -z "$PKG_CONFIG"; then
> +		AC_MSG_ERROR([pkg-config not installed; please install it.])
> +	fi
> +
> +	AC_CHECK_LIB(uuid, uuid_generate,
> +		[LIBBLKID=`$PKG_CONFIG --libs uuid`;
                 ^^^^^^^^
> +		 STATIC_LIBBLKID=`$PKG_CONFIG --static --libs uuid`],
                 ^^^^^^^^^^^^^^^
> +		[AC_MSG_ERROR([external uuid library not found])],
> +		[$LIBUUID])
> +	UUID_CMT=#
> +	AC_MSG_RESULT([Disabling private uuid library])

I'll have a corrected patch checked into e2fsprogs.

							- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html