linux-ext4 - Re: [PATCH] libext2fs: ensure validate_entry doesn't read beyond blocksize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090629052701.GD6802@mit.edu>
Date:	Mon, 29 Jun 2009 01:27:01 -0400
From:	Theodore Tso <tytso@....edu>
To:	number9652 <number9652@...oo.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] libext2fs: ensure validate_entry doesn't read beyond
	blocksize

On Fri, Jun 12, 2009 at 09:04:32AM -0700, number9652 wrote:
> 
> ext2fs_validate_entry would read beyond the end of the block to get dirent->rec_len for certain arguments (like if blocksize == final_offset).  This patch adds a check so that doesn't happen, and changes the types of the arguments to avoid a compiler warning.
> 
> Signed-off-by: Nic Case <number9652@...oo.com>

Applied.  In the future, please line-wrap the body of the commit
message at 72-75 characters.

I also lined up the arguments to ext2fs_validate_entry on the
continuation line, and used a CPP macro instead of an automatic
variable for dirent_min_length.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html