linux-ext4 - Re: [PATCH] resize2fs: If resize2fs fails, tell the user to run e2fsck

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <20090710184255.GF12939@webber.adilger.int>
Date:	Fri, 10 Jul 2009 12:42:55 -0600
From:	Andreas Dilger <adilger@....com>
To:	"Theodore Ts'o" <tytso@....edu>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] resize2fs: If resize2fs fails, tell the user to run	e2fsck

On Jul 10, 2009  14:07 -0400, Theodore Ts'o wrote:
> If the resize operation fails in the middle of the operation, mark the
> filesystem as needing to be checked, and tell the user that they
> should run e2fsck -fy on the device.

Isn't it a bit late to mark the filesystem inconsistent AFTER the resize
failed?  If resize2fs dies for some reason it won't be marked.  It makes
more sense to mark the filesystem in error at the start (at first change
at least) and then clear it if there was no error.

> Signed-off-by: "Theodore Ts'o" <tytso@....edu>
> ---
>  resize/main.c |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/resize/main.c b/resize/main.c
> index 2dae161..990a967 100644
> --- a/resize/main.c
> +++ b/resize/main.c
> @@ -455,7 +455,12 @@ int main (int argc, char ** argv)
>  	if (retval) {
>  		com_err(program_name, retval, _("while trying to resize %s"),
>  			device_name);
> -		ext2fs_close (fs);
> +		fprintf(stderr,
> +			_("Please run 'e2fsck -fy %s' to fix the filesystem\n"
> +			  "after the aborted resize operation"), device_name);
> +		fs->super->s_state |= EXT2_ERROR_FS;
> +		ext2fs_mark_super_dirty(fs);
> +		ext2fs_close(fs);
>  		exit(1);
>  	}
>  	printf(_("The filesystem on %s is now %u blocks long.\n\n"),
> -- 
> 1.6.3.2.1.gb9f7d.dirty
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html