linux-ext4 - Re: [PATCH] Fix buffer head reference leak in no-journal mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090713130829.GB12833@mit.edu>
Date:	Mon, 13 Jul 2009 09:08:29 -0400
From:	Theodore Tso <tytso@....edu>
To:	Curt Wohlgemuth <curtw@...gle.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] Fix buffer head reference leak in no-journal mode

On Thu, Jul 09, 2009 at 10:10:55AM -0700, Curt Wohlgemuth wrote:
> We found a problem with buffer head reference leaks when using an ext4
> partition without a journal.  In particular, calls to ext4_forget() would
> not to a brelse() on the input buffer head, which will cause pages they
> belong to to not be reclaimable.
> 
> Further investigation showed that all places where ext4_journal_forget() and
> ext4_journal_revoke() are called are subject to the same problem.  The patch
> below changes __ext4_journal_forget/__ext4_journal_revoke to do an explicit
> release of the buffer head when the journal handle isn't valid.
> 
> 	Signed-off-by: Curt Wohlgemuth <curtw@...gle.com>

Thanks, applied.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html