linux-ext4 - Re: [PATCH] jbd2: Fix a race between checkpointing code and journal_get_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090713132958.GC12293@duck.suse.cz>
Date:	Mon, 13 Jul 2009 15:29:58 +0200
From:	Jan Kara <jack@...e.cz>
To:	Theodore Tso <tytso@....edu>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] jbd2: Fix a race between checkpointing code and
	journal_get_write_access()

On Mon 13-07-09 09:19:01, Theodore Tso wrote:
> On Fri, Jul 10, 2009 at 12:07:13PM +0200, Jan Kara wrote:
> >   Yes, it should be "this should never happen", unless you run something
> > like tune2fs while the filesystem is mounted. But looking at the code, I
> > have missed that buffer could be dirty also in
> > jbd2_journal_get_create_access() because jbd2_journal_forget() does not
> > clear the dirty bit in case the buffer is just being committed. Attached
> > patch should fix it. Thanks for report.
> 
> Thanks, added to the patch queue.
  I've been doing some more tests here and there's one more path which emits
the warning when deleting symlinks (falsely this time). I'll send you the fix
when I verify that I cannot trigger the warning anymore.

									Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html