| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20090715061856.GB17310@skywalker> Date: Wed, 15 Jul 2009 11:48:56 +0530 From: "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com> To: Jan Kara <jack@...e.cz> Cc: linux-ext4@...r.kernel.org, tytso@....edu Subject: Re: [PATCH 2/2] ext4: Fix truncation of symlinks after failed write On Mon, Jul 13, 2009 at 09:29:27PM +0200, Jan Kara wrote: > Contents of long symlinks is written via standard write methods. So when the > write fails, we add inode to orphan list. But symlinks don't have .truncate > method defined so nobody properly removes them from the on disk orphan list. > > Fix this by calling ext4_truncate() directly instead of calling vmtruncate() > (which is saner anyway since we don't need anything vmtruncate() does except > from calling .truncate in these paths). We are fixing below by not adding the inode to orphan list if they don't have a .truncate call back right ?. So changing vmtruncate to ext4_truncate is not be really needed to fix the problem right ? >We also add inode to orphan list only > if ext4_can_truncate() is true (currently, it can be false for symlinks when > there are no blocks allocated) - otherwise orphan list processing will complain > and ext4_truncate() will not remove inode from on-disk orphan list. > -aneesh -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists