linux-ext4 - Re: [PATCH] xfstests: very basic defragmentation testing for xfs & ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A61F895.9090704@redhat.com>
Date:	Sat, 18 Jul 2009 11:30:13 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Christoph Hellwig <hch@...radead.org>
CC:	xfs mailing list <xfs@....sgi.com>,
	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] xfstests: very basic defragmentation testing for xfs
 &	ext4

Christoph Hellwig wrote:
> On Wed, Jul 15, 2009 at 03:21:11PM -0500, Eric Sandeen wrote:

...

>> (md5sums may just be reading buffered data though,
>> suggestions?)
> 
> As Andreas said unmount it before.
> 
>> The test currently expects to find e4defrag in
>> /usr/bin
> 
>> +_supported_fs xfs ext4
> 
>> +fragfile=$SCRATCH_MNT/fragfile.$$
>> +
>> +if [ "$FSTYP" == "xfs" ]; then
>> +	DEFRAG=/usr/sbin/xfs_fsr
>> +else
>> +	DEFRAG=/usr/bin/e4defrag
>> +fi
>> +
>> +_require_command $DEFRAG
>> +_require_command /usr/sbin/filefrag
> 
> I think we're much better off adding a helpers for this in a new
> common.defrag (or adding it somwhere).
> 
> Then set a DEFRAF_PROG variable there, and add a _require_defrag
> ala


Both ideas sound good, will send a V2.

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html