linux-ext4 - Re: [PATCH 1/5] e4defrag: return more specific error message on ioctl failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A6391DF.3090105@redhat.com>
Date:	Sun, 19 Jul 2009 16:36:31 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Peng Tao <bergwolf@...il.com>
CC:	linux-ext4@...r.kernel.org, tytso@....edu
Subject: Re: [PATCH 1/5] e4defrag: return more specific error message on ioctl
 failure

Peng Tao wrote:
> Currently e4defrag relies on the EXT4_IOC_MOVE_EXT ioctl to perform online
> defragmentation. However, this iotcl kernel patch is not available before
> 2.6.30-rc1. e4defrag shall fail without obvious reasons on systems running
> older kernels. The patch adds more detailed error message addressing this
> issue and prompts users with the minimal kernel version that is needed to
> run e4defrag.
> 
> Signed-off-by: Peng Tao <bergwolf@...il.com>
> ---
>  misc/e4defrag.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/misc/e4defrag.c b/misc/e4defrag.c
> index c25514a..f1c3008 100644
> --- a/misc/e4defrag.c
> +++ b/misc/e4defrag.c
> @@ -1553,7 +1553,11 @@ static int call_defrag(int fd, int donor_fd, const char *file,
>  			if (mode_flag & DETAIL) {
>  				printf("\n");
>  				PRINT_ERR_MSG_WITH_ERRNO(
> -						"Failed to defrag");
> +					"Failed to defrag with "
> +					"EXT4_IOC_MOVE_EXT ioctl");
> +				if (errno == ENOTTY)
> +					printf("\tAt least 2.6.31-rc1 of"
> +						" vallina kernel is required\n");

Typo here, s/b "vanilla"

-Eric

>  			} else {
>  				printf("\t[ NG ]\n");
>  			}

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html