linux-ext4 - Re: [PATCH 5/5] Makefile.in: allow make install e4defrag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A63F0B1.7090002@gmail.com>
Date:	Mon, 20 Jul 2009 12:21:05 +0800
From:	Peng Tao <bergwolf@...il.com>
To:	Eric Sandeen <sandeen@...hat.com>
CC:	linux-ext4@...r.kernel.org, tytso@....edu
Subject: Re: [PATCH 5/5] Makefile.in: allow make install e4defrag

Hi, Eric
Eric Sandeen wrote:
> Peng Tao wrote:
>> Current Makefile does not install e4defrag nor e4defrag.8.
>> Change misc/Makefile.in to make the e4defrag available for use.
>>
>> Signed-off-by: Peng Tao <bergwolf@...il.com>
> 
> Since this is all still fairly developmental at this point (I think?)
> perhaps a special "make install-e4defrag" target might be best.
> 
> Otherwise packages which "make install" will start shipping e4defrag,
> and I'm not sure we want to do that quite yet.
Thanks for your reviewing. Does the following patch meet your expectation?

>From 248322ee72e371dcd1b302400d787f9f2eec15cd Mon Sep 17 00:00:00 2001
From: Peng Tao <bergwolf@...il.com>
Date: Mon, 20 Jul 2009 12:01:55 +0800
Subject: [PATCH-e2fsprogs] Makefile.in: add install-e4defrag target

The e4defrag program is still developmental, but we can make it available
for use if someone wants to test it.

Signed-off-by: Peng Tao <bergwolf@...il.com>
---
 Makefile.in      |    3 +++
 misc/Makefile.in |    6 +++++-
 2 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/Makefile.in b/Makefile.in
index 45f2972..1c2b44e 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -57,6 +57,9 @@ clean-doc:
 distclean-doc:
 	-test -d doc && cd doc && $(MAKE) distclean
 
+install-e4defrag: subs all-libs-recursive
+	$(MAKE) -C misc install-e4defrag
+
 install: subs all-libs-recursive install-progs-recursive \
   install-shlibs-libs-recursive install-doc-libs
 	if test ! -d e2fsck && test ! -d debugfs && test ! -d misc && test ! -d ext2ed ; then $(MAKE) install-libs ; fi
diff --git a/misc/Makefile.in b/misc/Makefile.in
index 5f5dab5..029a201 100644
--- a/misc/Makefile.in
+++ b/misc/Makefile.in
@@ -399,6 +399,10 @@ installdirs:
 		$(DESTDIR)$(man1dir) $(DESTDIR)$(man5dir) \
 		$(DESTDIR)$(libdir) $(DESTDIR)/$(root_sysconfdir)
 
+install-e4defrag: e4defrag e4defrag.8 installdirs
+	$(INSTALL_PROGRAM) e4defrag $(DESTDIR)$(bindir)/e4defrag
+	$(INSTALL_DATA) e4defrag.8 $(DESTDIR)$(man8dir)/e4defrag.8
+
 install: all $(SMANPAGES) $(UMANPAGES) installdirs
 	$(Q) for i in $(SPROGS); do \
 		echo "	INSTALL $(root_sbindir)/$$i"; \
@@ -556,7 +560,7 @@ clean:
 		blkid.profiled tune2fs.profiled e2image.profiled \
 		e2undo.profiled mke2fs.profiled dumpe2fs.profiled \
 		logsave.profiled filefrag.profiled uuidgen.profiled \
-		uuidd.profiled e2image.profiled \
+		uuidd.profiled e2image.profiled e4defrag \
 		profiled/*.o \#* *.s *.o *.a *~ core gmon.out
 
 mostlyclean: clean
-- 
1.6.2-rc2.GIT



-- 
Best Regards,
Peng Tao
State Key Laboratory of Networking and Switching Technology
Beijing Univ. of Posts and Telecoms.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html