linux-ext4 - Re: ioctl32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A69E12F.2070904@redhat.com>
Date:	Fri, 24 Jul 2009 11:28:31 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Andi Kleen <andi@...stfloor.org>
CC:	Andreas Dilger <adilger@....com>,
	Ron Johnson <ron.l.johnson@....net>, linux-ext4@...r.kernel.org
Subject: Re: ioctl32

Andi Kleen wrote:
> Eric Sandeen <sandeen@...hat.com> writes:
>> /* pointer to compatible structure or no argument */
>> #define COMPATIBLE_IOCTL(cmd) \
>>         { (cmd), do_ioctl32_pointer },
> 
> 
> The modern way to do this is to use the ->compat_ioctl VFS
> method. COMPATIBLE_IOCTL etc are all obsolete.
> 
>> I think adding COMPATIBLE_IOCTL(FS_IOC_FIEMAP); to fs/compat_ioctl.c
>> should be enough, I'll try to get it tested tomorrow.
> 
> Nope, add a ->compat_ioctl 
> 
> When your ioctl is already a unlocked_ioctl you can just use
> the same function. If not convert to unlocked_ioctl first.
> 
> -Andi

Ok thanks, I knew I needed to revisit it.  ;)

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html