linux-ext4 - [patch 1/1] ext4: remove redundant test on unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 06 Aug 2009 16:07:21 -0700
From:	akpm@...ux-foundation.org
To:	tytso@....edu
Cc:	linux-ext4@...r.kernel.org, akpm@...ux-foundation.org,
	roel.kluin@...il.com
Subject: [patch 1/1] ext4: remove redundant test on unsigned

From: Roel Kluin <roel.kluin@...il.com>

unsigned i_block cannot be less than 0.

Signed-off-by: Roel Kluin <roel.kluin@...il.com>
Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
---

 fs/ext4/inode.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff -puN fs/ext4/inode.c~ext4-remove-redundant-test-on-unsigned fs/ext4/inode.c
--- a/fs/ext4/inode.c~ext4-remove-redundant-test-on-unsigned
+++ a/fs/ext4/inode.c
@@ -343,9 +343,7 @@ static int ext4_block_to_path(struct ino
 	int n = 0;
 	int final = 0;
 
-	if (i_block < 0) {
-		ext4_warning(inode->i_sb, "ext4_block_to_path", "block < 0");
-	} else if (i_block < direct_blocks) {
+	if (i_block < direct_blocks) {
 		offsets[n++] = i_block;
 		final = direct_blocks;
 	} else if ((i_block -= direct_blocks) < indirect_blocks) {
_
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html