linux-ext4 - Re: [PATCH] Compile warning fix when enable EXT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A82E41F.2050702@redhat.com>
Date:	Wed, 12 Aug 2009 10:47:43 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Mingming <cmm@...ibm.com>
CC:	linux-ext4@...r.kernel.org, Theodore Tso <tytso@....edu>
Subject: Re: [PATCH] Compile warning fix when enable EXT_DEBUG

Mingming wrote:
> When enable EXT_DEBUG I got the following compile warning on PPC64
> 
>   CC [M]  fs/ext4/inode.o
>   CC [M]  fs/ext4/extents.o
> fs/ext4/extents.c: In function ‘ext4_ext_rm_leaf’:
> fs/ext4/extents.c:2097: warning: format ‘%lu’ expects type ‘long unsigned int’, but argument 2 has type ‘ext4_lblk_t’
> fs/ext4/extents.c: In function ‘ext4_ext_get_blocks’:
> fs/ext4/extents.c:2789: warning: format ‘%u’ expects type ‘unsigned int’, but argument 4 has type ‘long unsigned int’
> fs/ext4/extents.c:2852: warning: format ‘%lu’ expects type ‘long unsigned int’, but argument 3 has type ‘ext4_lblk_t’
> fs/ext4/extents.c:2953: warning: format ‘%lu’ expects type ‘long unsigned int’, but argument 4 has type ‘unsigned int’
>   CC [M]  fs/ext4/migrate.o
> 
> The patch fixed compile warning.

and a little bit more ... :)

> Signed-off-by: Mingming Cao <cmm@...ibm.com>
> 
> Index: linux-2.6.31-rc4/fs/ext4/extents.c
> ===================================================================
> --- linux-2.6.31-rc4.orig/fs/ext4/extents.c
> +++ linux-2.6.31-rc4/fs/ext4/extents.c
> @@ -2105,7 +2105,8 @@ ext4_ext_rm_leaf(handle_t *handle, struc
>  		else
>  			uninitialized = 0;
>  
> -		ext_debug("remove ext %lu:%u\n", ex_ee_block, ex_ee_len);
> +		ext_debug("remove ext %u:[%d]%d\n", ex_ee_block,
> +			 ext4_ext_is_uninitialized(ex), ex_ee_len);
>  		path[depth].p_ext = ex;

Shouldn't part of this be in your next patch, [PATCH]Show unwritten
extent flag in ext4_ext_show_leaf() ?

Thanks,
-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html