linux-ext4 - Re: [patch 06/11] ext2: convert to use the new truncate convention.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090821140659.GC20935@atrey.karlin.mff.cuni.cz>
Date:	Fri, 21 Aug 2009 16:06:59 +0200
From:	Jan Kara <jack@...e.cz>
To:	npiggin@...e.de
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-fsdevel@...r.kernel.org, Christoph Hellwig <hch@....de>,
	linux-ext4@...r.kernel.org
Subject: Re: [patch 06/11] ext2: convert to use the new truncate convention.

>   Hi,
> 
> > I also have commented a possible bug in existing ext2 code, marked with XXX.
>   Looks good, except:
> 
> > +int ext2_setsize(struct inode *inode, loff_t newsize)
>   This could be static.
> 
> > @@ -1459,8 +1540,15 @@ int ext2_setattr(struct dentry *dentry,
> >  		if (error)
> >  			return error;
> >  	}
> > -	error = inode_setattr(inode, iattr);
> > +	if (iattr->ia_valid & ATTR_SIZE) {
> > +		error = ext2_setsize(inode, iattr->ia_size);
> > +		if (error)
> > +			return error;
> > +	}
> > +	generic_setattr(inode, iattr);
>   Here, we should store the error code I suppose...
  Ah, I was confused. generic_setattr() returns void. But then remove
the check !error from:
  if (!error && (iattr->ia_valid & ATTR_MODE))
which just follows the generic_setattr(). That's what made me think
generic_setattr() returns something :)

									Honza
-- 
Jan Kara <jack@...e.cz>
SuSE CR Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html