lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 2 Sep 2009 18:09:39 -0400
From:	Greg Freemyer <greg.freemyer@...il.com>
To:	Peng Tao <bergwolf@...il.com>
Cc:	linux-ext4@...r.kernel.org, Theodore Tso <tytso@....edu>,
	Akira Fujita <a-fujita@...jp.nec.com>
Subject: Re: [PATCH] e4defrag: fallocate donor file only once

On Wed, Sep 2, 2009 at 11:35 AM, Peng Tao<bergwolf@...il.com> wrote:
> If we allocate the donor file once for all, it will have a better chance
> to be continuous.
>
> Signed-off-by: "Peng Tao" <bergwolf@...il.com>

Seems like an improvement, but I'm not seeing any special handling for
sparse files.  (Not before or after this patch.)

Seems like there should be an outer loop that identifies contiguous
data block sets in a sparse file and defrags them individually as
opposed to trying to defrag the entire file at once.

My impression is that with a large sparse file, e4defrag currently
(with or without this patch) would fallocate a full non-sparse donor
set of blocks the full size of the original file, then swap in just
the truly allocated blocks?

If so, that is not very optimum.

Greg
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists