linux-ext4 - Re: [PATCH] libext2fs: use ext2fs_blocks_count() in ext2fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <15413.1251933142@alphaville.usa.hp.com>
Date:	Wed, 02 Sep 2009 19:12:22 -0400
From:	Nick Dokos <nicholas.dokos@...com>
To:	Theodore Tso <tytso@....edu>
Cc:	Nick Dokos <nicholas.dokos@...com>,
	Eric Sandeen <sandeen@...hat.com>,
	Justin Maggard <jmaggard10@...il.com>,
	Andreas Dilger <adilger@....com>,
	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] libext2fs: use ext2fs_blocks_count() in ext2fs_open2() 

> On Wed, Sep 02, 2009 at 05:02:22PM -0400, Nick Dokos wrote:
> > The following patch fixes a problem I think, but I'm not sure whether it
> > resolves Justin's problem. I'm running a test, but I thought I'd send it
> > out for people to try and/or comment on. Let me know of any problems.
> 
> Ouch.  Thanks for sending this; I'm surprised people hadn't run into
> massive problems due to this patch earlier.
> 

Most of the time those counts fit in 16 bits (they are per block group,
is that right?) - at least with default values: you'd have to make a
file system with larger block groups to see the problem, I think.  So
it's not as painful as it first sounds.

Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html