linux-ext4 - Re: [PATCH] e2fsck: avoid overflow in pass5 check_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090906175718.GM3055@mit.edu>
Date:	Sun, 6 Sep 2009 13:57:18 -0400
From:	Theodore Tso <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] e2fsck: avoid overflow in pass5 check_block_end()

On Tue, Sep 01, 2009 at 05:40:28PM -0500, Eric Sandeen wrote:
> When making a filesystem as in:
> 
> mke2fs -E lazy_itable_init=1 -O uninit_bg -b 4096 bigfile 4294967298
> 
> a subsequent fsck would result in:
> 
> Pass 5: Checking group summary information
> Internal error: fudging end of bitmap (3)
> e2fsck: aborted
> 
> This is because check_block_end() was overflowing in the calculation
> for "end", and giving it a value of -1 (0xFFFF....) which eventually
> ended up tripping up a test in ext2fs_fudge_generic_bmap_end,
> 
>         if (end > bitmap->real_end)
>                 return neq;
> 
> Fix another such error in read_bitmaps() as well.
> 
> lib/ext2fs/imager.c likely has similar problems but it looks like
> it has no 64-bit treatment at all yet.

Applied to the e2fsprogs 64-bit patch queue / pu.

	       		 	      	      - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html