linux-ext4 - Re: [PATCH 0/3][RFC] add a message in mount/remount/umount for ext2/ext3/ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AAFAFAE.2090801@redhat.com>
Date:	Tue, 15 Sep 2009 10:15:58 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Toshiyuki Okajima <toshi.okajima@...fujitsu.com>
CC:	tytso@....edu, akpm@...ux-foundation.org, sct@...hat.com,
	adilger@....com, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 0/3][RFC] add a message in mount/remount/umount for ext2/ext3/ext4

Toshiyuki Okajima wrote:
> Hi Ted, Andrew and all.
> 
> Under the current implementation, we cannot know in the system log 
> (/var/log/messages) when the filesystem (ext2/ext3/ext4) is unmounted.
> For enterprise users, they often want to observe certain filesystems'
> actions (mount/unmount) in the system log. Besides, by the system log, 
> we occasionally wants to know whether a certain filesystem has been
> unmounted or not at the time when a problem happens.
> 
> The following patch series implement above demand. 
> Please apply it.

If this is really a common requirement, perhaps we should at least
consider putting it in the vfs, in  vfs_kern_mount(),
generic_shutdown_super(), and do_remount_sb().

That way we'll have common behavior and less replicated code; nothing in
this patch series is unique to ext[234] as far as I can tell.

sb->s_type->name could be used to print the fs type in a generic message.

-Eric

> Signed-off-by: Toshiyuki Okajima <toshi.okajima@...fujitsu.com>
> ---
>  fs/ext2/super.c |   16 ++++++++++++++++
>  fs/ext3/super.c |   32 +++++++++++++++++++++++---------
>  fs/ext4/super.c |   30 ++++++++++++++++++++++--------
>  3 files changed, 61 insertions(+), 17 deletions(-)
> 
> Regards,
> Toshiyuki Okajima
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html