[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6601abe90909181133g27458301nb3aae756e473541c@mail.gmail.com>
Date: Fri, 18 Sep 2009 11:33:04 -0700
From: Curt Wohlgemuth <curtw@...gle.com>
To: Andreas Dilger <adilger@....com>
Cc: ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 2/2] ext4: Handle nested ext4_journal_start/stop calls
without a journal
On Thu, Sep 17, 2009 at 10:50 PM, Andreas Dilger <adilger@....com> wrote:
> On Sep 17, 2009 14:55 -0700, Curt Wohlgemuth wrote:
>> This patch fixes a problem with handling nested calls to
>> ext4_journal_start/ext4_journal_stop, when there is no journal present.
>>
>> Signed-off-by: Curt Wohlgemuth <curtw@...gle.com>
>> ---
>>
>> Instead of using the special value of
>>
>> (handle_t *)0x1
>>
>> to represent a handle when there is no journal present, we now use a real
>> handle_t, so we can use its ref counting. The h_transaction field now
>> determines if there is a journal present or not.
>
> You _could_ just use the "handle" value as a refcount, and anything less
> than, say, 4096 is considered a "special" handle. I can't imagine the
> refcount being more than 3 or 4 even in extreme cases.
That's an elegant idea; thanks. I'll work this up and send a patch out for it.
Thanks,
Curt
>
> Cheers, Andreas
> --
> Andreas Dilger
> Sr. Staff Engineer, Lustre Group
> Sun Microsystems of Canada, Inc.
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists