linux-ext4 - Re: [PATCH, RFC] mke2fs: get device topology values from blkid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AB44A18.2090104@redhat.com>
Date:	Fri, 18 Sep 2009 22:03:52 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Karel Zak <kzak@...hat.com>
CC:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH, RFC] mke2fs: get device topology values from blkid

Karel Zak wrote:
> On Thu, Sep 17, 2009 at 05:22:49PM -0500, Eric Sandeen wrote:
>> +static errcode_t ext2fs_get_device_geometry(const char *file,
>> +					    struct ext2_super_block *fs_param)
>> +{

...

>> +	fs_param->s_raid_stride = min_io / blocksize;
>> +	fs_param->s_raid_stripe_width = opt_io / blocksize;
>> +	rc = 0;
>> +out:
> 
>    blkid_free_probe(pr);
> 
> just in case you want to keep valgrind mem-leak checkers silent :-) 

ok :)  If you haven't already updated your mkfs sample 
(blkid/samples/mkfs.c), now's the time to do so; I'll blame my error on 
cut and paste.  :)

Thanks,
-Eric

>> +	close(fd);
>> +	return rc;
>> +}
> 
>     Karel

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html