linux-ext4 - Re: [PATCH 3/3][RFC](Repost) ext4: add a message in remount/umount for ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091001035544.GT24383@mit.edu>
Date:	Wed, 30 Sep 2009 23:55:44 -0400
From:	Theodore Tso <tytso@....edu>
To:	Toshiyuki Okajima <toshi.okajima@...fujitsu.com>
Cc:	akpm@...ux-foundation.org, adilger@....com, sandeen@...hat.com,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 3/3][RFC](Repost) ext4: add a message in remount/umount
	for ext4

On Thu, Oct 01, 2009 at 12:20:17PM +0900, Toshiyuki Okajima wrote:
> I am recognizing it. But I think I have already explained its answer as follows:
>  - A print mechanism has already been included at mount time.

It's true that some file systems already are printing a message at
mount time; but when we abstract up something to the VFS layer, that's
also an opportunity to remove some kernel printk's from some
filesystems, including ext2/3/4 at the same time this feature is
introduced.

> > filesystem specific information, but that could be handled via a new
> > method function in struct super_ops:
> >
> >        mount_msg(struct super *sb, char *buf, int buflen)
> >

Note that what I was assuming is that we would is something like this
in the VFS mount code:

     printk(KERN_INFO "Device %s mounted file system type %s read-%s%s\n",
            sb->s_sid, sb->s_type->name, 
	    sb->s_flags & MS_RDONLY ? "only" : "write",
	    sb->s_op->mount_msg ? sb->s_op->mount_msg(sb) : "");

The advantage of this is that we would now have a single consistent
kernel message for all file systems, with some room for file system
specific message.

						- Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html