linux-ext4 - Re: [PATCH] e2fsprogs: clean up ext2fs_bg_flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091005115102.GC13512@mit.edu>
Date:	Mon, 5 Oct 2009 07:51:02 -0400
From:	Theodore Tso <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] e2fsprogs: clean up ext2fs_bg_flags_ interfaces

On Wed, Sep 09, 2009 at 02:03:47PM -0500, Eric Sandeen wrote:
> The ext2fs_bg_flag* functions were confusing.
>
> Currently we have this:
>
> void ext2fs_bg_flags_set(ext2_filsys fs, dgrp_t group, __u16 bg_flags);
> void ext2fs_bg_flags_clear(ext2_filsys fs, dgrp_t group,__u16 bg_flags);
>
> (_set (unused) sets exactly bg_flags; _clear clears all and ignores bg_flags)
>
> and these, which can twiddle individual bits in bg_flags:
>
> void ext2fs_bg_flag_set(ext2_filsys fs, dgrp_t group, __u16 bg_flag);
> void ext2fs_bg_flag_clear(ext2_filsys fs, dgrp_t group, __u16 bg_flag);
>
> A better interface, after the patch below, is just:
>
> ext2fs_bg_flags_zap(fs, group) /* zeros bg_flags */
> ext2fs_bg_flags_set(fs, group, flags) /* adds flags to bg_flags */
> ext2fs_bg_flags_clear(fs, group, flags) /* clears flags in bg_flags */
>

Applied.  I also (for consistency's sake) converted
ext2fs_bg_flag_test() to ext2fs_bg_flags_test() in a separate commit.

							- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html