linux-ext4 - Re: [PATCH 2/2] pu branch: make fs->group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091005145723.GG13512@mit.edu>
Date:	Mon, 5 Oct 2009 10:57:23 -0400
From:	Theodore Tso <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 2/2] pu branch: make fs->group_desc opaque

On Thu, Sep 24, 2009 at 09:35:47PM -0500, Eric Sandeen wrote:
> To prevent direct array indexing of fs->group_desc[i] (because
> the group_desc may be a different size for different filesystems)
> make it an opaque pointer that may only be accessed through the
> accessor functions in blknum.c.  The type itself is still available
> in a public header; if we have a group_desc that we know is one type
> or another, it's ok to access its fields directly.  This change only
> prevents us from indexing off fs->group_desc[i] directly.
>
> Change the accessors in blknum.c to use ext4fs_group_desc(), a version
> of ext2fs_group_desc() which returns a ext3_group_desc pointer.
>
> This simplifies and collapses a fair bit of code in blknum.c
>
> Tested with "make check" but no 64-bit testing yet.
>
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>

Thanks, I've added it to the pu branch in my sources.

	     	      	     		      - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html