linux-ext4 - Re: [PATCH 4/4] ext4: Wait for proper transaction commit on fsync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091020155243.GA25760@duck.suse.cz>
Date:	Tue, 20 Oct 2009 17:52:43 +0200
From:	Jan Kara <jack@...e.cz>
To:	Curt Wohlgemuth <curtw@...gle.com>
Cc:	Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org, tytso@....edu,
	chris.mason@...cle.com
Subject: Re: [PATCH 4/4] ext4: Wait for proper transaction commit on fsync

On Tue 20-10-09 07:36:55, Curt Wohlgemuth wrote:
> On Tue, Oct 20, 2009 at 12:24 AM, Jan Kara <jack@...e.cz> wrote:
> > We cannot rely on buffer dirty bits during fsync because pdflush can come
> > before fsync is called and clear dirty bits without forcing a transaction
> > commit. What we do is that we track which transaction has last changed
> > the inode and which transaction last changed allocation and force it to
> > disk on fsync.
<snip>
> > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> > index 10539e3..3e167f6 100644
> > --- a/fs/ext4/extents.c
> > +++ b/fs/ext4/extents.c
> > @@ -3315,6 +3315,11 @@ int ext4_ext_get_blocks(handle_t *handle, struct inode *inode,
> >        newblock = ext_pblock(&newex);
> >        allocated = ext4_ext_get_actual_len(&newex);
> >        set_buffer_new(bh_result);
> > +
> > +       atomic_set(&EXT4_I(inode)->i_sync_tid, handle->h_transaction->t_tid);
> > +       atomic_set(&EXT4_I(inode)->i_datasync_tid,
> > +                  handle->h_transaction->t_tid);
> > +       printk("Datasync tid %u\n", handle->h_transaction->t_tid);
> 
> Both here and in ext4_ind_get_blocks() below, I think you need to
> guard the atomic_set() calls with ext4_handle_valid().
  Ah, good point. Will fix.

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html