linux-ext4 - Re: [PATCH 1/2] ext4: journal all modifications in ext4_xattr_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AF4A49F.8030005@redhat.com>
Date:	Fri, 06 Nov 2009 16:35:11 -0600
From:	Eric Sandeen <sandeen@...hat.com>
To:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 1/2] ext4: journal all modifications in ext4_xattr_set_handle

Eric Sandeen wrote:
> ext4_xattr_set_handle() was modifying s_inode_size outside
> of journaling constraints; this is one of the accesses that
> was causing the crc errors in journal replay as seen in
> kernel.org bugzilla #14354.

Oh, and for those who haven't been following the bug, big
thanks to Chris Mason for helping to look into this and coming
up with the debugging patch that made it obvious...

-Eric

> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
> ---
> 
> diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
> index fed5b01..0257019 100644
> --- a/fs/ext4/xattr.c
> +++ b/fs/ext4/xattr.c
> @@ -988,6 +988,10 @@ ext4_xattr_set_handle(handle_t *handle, struct 
> inode *inode, int name_index,
>     if (error)
>         goto cleanup;
> 
> +    error = ext4_journal_get_write_access(handle, is.iloc.bh);
> +    if (error)
> +        goto cleanup;
> +
>     if (EXT4_I(inode)->i_state & EXT4_STATE_NEW) {
>         struct ext4_inode *raw_inode = ext4_raw_inode(&is.iloc);
>         memset(raw_inode, 0, EXT4_SB(inode->i_sb)->s_inode_size);
> @@ -1013,9 +1017,6 @@ ext4_xattr_set_handle(handle_t *handle, struct 
> inode *inode, int name_index,
>         if (flags & XATTR_CREATE)
>             goto cleanup;
>     }
> -    error = ext4_journal_get_write_access(handle, is.iloc.bh);
> -    if (error)
> -        goto cleanup;
>     if (!value) {
>         if (!is.s.not_found)
>             error = ext4_xattr_ibody_set(handle, inode, &i, &is);
> 
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html