linux-ext4 - Re: [PATCH 1/2] ext4: partial revert to fix double brelse WARNING()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 7 Nov 2009 03:11:16 -0500
From:	Theodore Tso <tytso@....edu>
To:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 1/2] ext4: partial revert to fix double brelse WARNING()

On Sat, Nov 07, 2009 at 02:43:42AM -0500, Theodore Ts'o wrote:
> This is a partial revert of commit 6487a9d (only the changes made to
> fs/ext4/namei.c), since it is causing the following brelse() of an
> already free buffer when running fsstress on a file system with 1k
> blocksize:

This description isn't quite right.  I did get this error while
running fsstress on a file system with a 1k blocksize, but the real
problem was that I was using a device that wasn't big enough for
fsstress, and it was really an ENOSPC error while extending a
directory from 1 block.  Curt's patch didn't take into account that
the call to ext4_append() in make_indexed_dir() could also return
ENOSPC, that would cause a double brelse().

I suppose I could have fixed it up by adding an explicit check for
ENOSPC and not freeing the buffer head in that one return path, which
would have made for a smaller patch, but the resulting code would be
really horrible.  So I still think the best thing to do for now is to
partially revert commit 6487a9d now, and fix things up cleanly after
2.6.32 is released.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html