linux-ext4 - [PATCH] EXT4: Add missing brelse() in ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091107221732.GA16212@basil.fritz.box>
Date:	Sat, 7 Nov 2009 23:17:32 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	tytso@....edu, linux-ext4@...r.kernel.org
Subject: [PATCH] EXT4: Add missing brelse() in ext4_iget()

EXT4: Add missing brelse() in ext4_iget()

One of the invalid error paths in ext4_iget() forgot to brelse() the inode
buffer head. Fix that.

Found during code review.

Signed-off-by: Andi Kleen <ak@...ux.intel.com>

---
 fs/ext4/inode.c |    1 +
 1 file changed, 1 insertion(+)

Index: linux-2.6.32-rc6-ak/fs/ext4/inode.c
===================================================================
--- linux-2.6.32-rc6-ak.orig/fs/ext4/inode.c
+++ linux-2.6.32-rc6-ak/fs/ext4/inode.c
@@ -4882,6 +4882,7 @@ struct inode *ext4_iget(struct super_blo
 	      (le32_to_cpu(EXT4_SB(sb)->s_es->s_first_data_block) +
 	       EXT4_SB(sb)->s_gdb_count)) ||
 	     (ei->i_file_acl >= ext4_blocks_count(EXT4_SB(sb)->s_es)))) {
+		brelse(bh);
 		ext4_error(sb, __func__,
 			   "bad extended attribute block %llu in inode #%lu",
 			   ei->i_file_acl, inode->i_ino);
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html