linux-ext4 - Re: [PATCH 2/2] ext2: add wait flag support to sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Nov 2009 09:08:58 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org,
	hch@...radead.org
Subject: Re: [PATCH 2/2] ext2: add wait flag support to sync_fs

On Fri, 20 Nov 2009 05:36:22 -0500
Christoph Hellwig <hch@...radead.org> wrote:

> On Thu, Nov 19, 2009 at 04:34:19PM +0100, Jan Kara wrote:
> >   BTW: Christoph, why did you choose to call ext2_sync_fs with wait == 1
> > from ext2_write_super()? I'd think (and looking into callsites seem to
> > confirm that) that ->write_super() was meant to be asynchronous...
> 
> No particular reason - the argument wasn't and still isn't used in ext2.
> And yes, now that ->sync_fs is mandatory ->write_super should be
> asynchronous.
> 

Shouldn't super block (and all other) updates be synchronous if ext2 
is mounted with SYNC and DIRSYNC?

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html