| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Nov 2009 14:29:01 +0100 From: Jan Kara <jack@...e.cz> To: Andrew Morton <akpm@...ux-foundation.org> Cc: Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org, tytso@....edu, chris.mason@...cle.com Subject: Re: [PATCH] ext2: Report metadata errors during fsync On Wed 25-11-09 13:48:58, Andrew Morton wrote: > On Wed, 25 Nov 2009 11:24:53 +0100 > Jan Kara <jack@...e.cz> wrote: > > > When an IO error happens while writing metadata buffers, we should better > > report it and call ext2_error since the filesystem is probably no longer > > consistent. Sometimes such IO errors happen while flushing thread does > > background writeback, the buffer gets later evicted from memory, and thus > > the only trace of the error remains as AS_EIO bit set in blockdevice's > > mapping. So we check this bit in ext2_fsync and report the error although > > we cannot be really sure which buffer we failed to write. > > So this doesn't cause significant changes in runtime behaviour unless > the operator specified errors=remount-ro or errors=panic? Yes, only log message in case errors=continue. OTOH errors=remount-ro is IMHO more common. But in case we detect metadata IO error (which is what I've added), calling ext2_error is desirable regardless of what it ends up doing. Honza -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists