linux-ext4 - Re: [PATCH] ext4: Remove blocks from inode prealloc list on failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091204011022.GI10985@thunk.org>
Date:	Thu, 3 Dec 2009 20:10:22 -0500
From:	tytso@....edu
To:	Curt Wohlgemuth <curtw@...gle.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: Remove blocks from inode prealloc list on failure

On Tue, Dec 01, 2009 at 10:17:02AM -0800, Curt Wohlgemuth wrote:
> This fixes a leak of blocks in an inode prealloc list if device failures
> cause ext4_mb_mark_diskspace_used() to fail.

I was going to say that it didn't make sense for
ext4_discard_inode_pa() should be its own function, but maybe we need
function that returns blocks back to the either inode *or* the group
preallocation list?  Otherwise right now it looks like we would also
be potentially leaking blocks from the group preallocation list in
case of a device failure?

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html