linux-ext4 - Re: [PATCH] replaced BUG() with return -EIO from ext4_ext_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1260562923.21896.11.camel@bobble.smo.corp.google.com>
Date:	Fri, 11 Dec 2009 12:22:03 -0800
From:	Frank Mayhar <fmayhar@...gle.com>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	Surbhi Palande <surbhi.palande@...onical.com>,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] replaced BUG() with return -EIO
	from	ext4_ext_get_blocks

On Fri, 2009-12-11 at 14:02 -0600, Eric Sandeen wrote:
> My first thought was that this was a bandaid too, but I guess it can
> come about due to on-disk corruption for any reason, so it should
> be handled gracefully, and I suppose this approach seems fine.

That's why we've been running with it, yes.

> Since this is catching on-disk corruption, though, it'd be better to call
> ext4_error() and let the mount-time error-handling policy decide what to do.
> 
> I like having more info but below seems awfully wordy ;)  Maybe the first
> printk would suffice, and switching it to an ext4_error() would be best,
> I think.

Okay, I'll rework the patch a bit and resubmit it.
-- 
Frank Mayhar <fmayhar@...gle.com>
Google, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html