linux-ext4 - Re: [PATCHv2 00/12]posix_acl: Add the check items

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <b3657a100912210615q1d55c334g73667e1c3a97ce05@mail.gmail.com>
Date:	Mon, 21 Dec 2009 22:15:26 +0800
From:	liu weni <qingshenlwy@...il.com>
To:	Christoph Hellwig <hch@....de>
Cc:	chris.mason@...cle.com, viro@...iv.linux.org.uk,
	joel.becker@...cle.com, cjb@...top.org, jmorris@...ei.org,
	serue@...ibm.com, akpm@...ux-foundation.org, adilger@....com,
	jack@...e.cz, tytso@....edu, dwmw2@...radead.xn.org.cpa,
	swhiteho@...hat.com, bfields@...ldses.org, neilb@...e.de,
	ffilzlnx@...ibm.com, bharrosh@...asas.com, mfasheh@...e.com,
	tiger.yang@...cle.com, jeffm@...e.com, aelder@....com,
	sandeen@...deen.net, xfs-masters@....sgi.com, xfs@....sgi.com,
	reiserfs-devel@...r.kernel.org, ocfs2-devel@....oracle.com,
	linux-nfs@...r.kernel.org, linux-ext4@...r.kernel.org,
	linux-btrfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, cluster-devel@...hat.com,
	linux-mtd@...ts.infradead.org, strongzgy@...il.com,
	onlyflyer@...il.com
Subject: Re: [PATCHv2 00/12]posix_acl: Add the check items

Thanks for your suggestion.

In my opinion the null point is a incorrect state for the acl, then I
return -EINVAL.

I will check this state transition in XFS.

2009/12/21 Christoph Hellwig <hch@....de>:
> I like taking these checks into posix_acl_valid, but I think the patch
> submission needs a bit more work.
>
> All the patches are extremly whitespace mangled.  And I don't think
> splitting them up makes a whole lot of sense, when we do API changes
> like this we usually fix up all callers.  So please try to fix your
> mailer, merged them all into one, and maybe also chose a more
> descriptive subject line, e.g.
>
> Subject: take checks for NULL and error pointers into posix_acl_valid()
>
>
> And btw, at least the XFS change seems incorrect - previously we
> returned NULL acl pointer and this patch changes it to -EINVAL.
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html