linux-ext4 - [PATCH] default max mount count to unused

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B5785A5.2010505@redhat.com>
Date:	Wed, 20 Jan 2010 16:37:25 -0600
From:	Eric Sandeen <sandeen@...hat.com>
To:	ext4 development <linux-ext4@...r.kernel.org>
CC:	Bill Nottingham <notting@...hat.com>
Subject: [PATCH] default max mount count to unused

From: Bill Nottingham <notting@...hat.com>

Anaconda has been setting the max mount count on the root fs
to -1 (unused) for ages.

I (Eric) tend to agree that using mount count as a proxy for potential
for corruption seems odd.  And waiting for fsck on a reboot just because
it's number 20 (or so) is painful.  Can we just turn it off by default?

I wouldn't mind killing the periodic check as well, but consider
this a trial balloon.  :)

Signed-off-by: Eric Sandeen <sandeen@...hat.com>
--- 

diff --git a/doc/libext2fs.texinfo b/doc/libext2fs.texinfo
index 19899bc..a0439bf 100644
--- a/doc/libext2fs.texinfo
+++ b/doc/libext2fs.texinfo
@@ -319,7 +319,8 @@ skip the filesystem check if the number of times that the filesystem has
 been mounted is less than @code{s_max_mnt_count} and if the interval
 between the last time a filesystem check was performed and the current
 time is less than @code{s_checkinterval} (see below).  The default value
-of @code{s_max_mnt_count} is 20.
+of @code{s_max_mnt_count} is -1 (which means that this check is not
+done).
 
 @item s_checkinterval
 This field defines the minimal interval between filesystem checks.  See
diff --git a/lib/ext2fs/ext2_fs.h b/lib/ext2fs/ext2_fs.h
index 114b001..b98d6e8 100644
--- a/lib/ext2fs/ext2_fs.h
+++ b/lib/ext2fs/ext2_fs.h
@@ -484,7 +484,7 @@ struct ext2_inode_large {
 /*
  * Maximal mount counts between two filesystem checks
  */
-#define EXT2_DFL_MAX_MNT_COUNT		20	/* Allow 20 mounts */
+#define EXT2_DFL_MAX_MNT_COUNT		-1	/* Don't use mount check */
 #define EXT2_DFL_CHECKINTERVAL		0	/* Don't use interval check */
 
 /*

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html